-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(material/tabs): ink bar animation not disabling when animationDuration set to 0 #25068
Comments
Is this really a bug ? So if you give it the value 0 or 0ms, the body will appear with no animation, but the To me, it looks like two very different things. I don't think the Also, removing the animation can be done by adding the |
Yes this is great and you can now check some information about it here on modern christening cakes where they have used it in a different shape. |
I would be eager to attempt to solve this issue! |
@markusingvarsson did you manage to get a PR up for this? I'd be happy to take a look |
…p and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
…p and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
Removed unnecessary code of a unit test that was added to test the ink bar animation synchronization with tab body, the PR that was intended to solve angular#25068. Fixes angular#25617
…p and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
…p and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
…p and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
Removed unnecessary code of a unit test that was added to test the ink bar animation synchronization with tab body, the PR that was intended to solve angular#25068. Fixes angular#25617
fix merge issues involving fix of angular#25068
Hey!! Is this issue still open. I would like to work on this. |
Hi @Gua00va , Yes. You are welcome to work on this. Community PRs are encouraged. -Zach |
import { MatTabGroup } from '@angular/material/tabs'; @component({ handleAnimationChange(event: AnimationEvent) { |
The animation of the ink bar of the mat tab group and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
The animation of the ink bar of the mat tab group and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
The animation of the ink bar of the mat tab group and the mat tab nav bar is now synchronized with the animationDuration of the tab body. When the animation duration of the tab body was set to e.g. 0ms the ink bar still had an animation of 500ms. The following feat extends the animationDuration property to not only affect the tab body but also the ink bar of the tab group and the tab nav bar. Fixes angular#25068
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Feature Description
I can set the animation duration for the tabs themselves using
animationDuration
on themat-tab-group
. If I set this to 0, the tabs switch instantly, but the ink bar moves across taking 500ms, which makes the tab switching look slower than it actually is.I can implement this myself using
ng-deep
:but
ng-deep
is deprecated, so there's always the risk this will stop working in the future.Use Case
Tab switching looks faster if tab switch animation duration is less than 500ms.
The text was updated successfully, but these errors were encountered: